Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

Conversation

@aluttik
Copy link
Contributor

@aluttik aluttik commented Jul 18, 2015

Changes

  • Fixed the strange permissions on most of 3rd party modules.
  • Added a source/temp folder that contains some newly converted files (these will be relocated when we decide where they should fit into the file system).
  • source/conf.py and some toctrees needed to be edited slightly to accommodate these new files.

Notes

  • Some of the new files have commented-out :doc: references because they point to files that will be added to the file system in the near future.
  • Multiple links in the source/temp/resources file were deemed broken by the link check, but there were many non-403/4 errors returned. They are all currently commented out and labeled as "dead links," however I intend to check them again before the next pull-request just in case some are just acting moody today.

Issues fixed

@aluttik
Copy link
Contributor Author

aluttik commented Jul 19, 2015

@LinuxJedi, do you know why the build fails on Shippable? I don't have permission to view the details.
Both make html and make linkcheck succeeded when I pushed the last three commits.

@LinuxJedi
Copy link
Contributor

broken http://dotimes.com/slackbuilds/nginx/ - [Errno 104] Connection reset by peer

Whatever that link is supposed to be, it is bad now. It does some weird things for me but doesn't show any useful content.

There are also a couple of permanent redirects which I would have thought would fail linkcheck too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you see this? I've not had issues with the IETF so far.

@aluttik
Copy link
Contributor Author

aluttik commented Jul 20, 2015

A few pages had links that were being temporarily picky (like the IEFT links were timing out then, but probably won't in the future). I commented out those links for the time being so that the pull request would pass the shippable test. I planned to uncomment many of them later when they're probably back to normal - that's why I labeled them by error number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad link

@LinuxJedi
Copy link
Contributor

If you commented those links out please mark these in the pull request so we can create a new issue to put them back afterwards. Don't worry if they cause transient failures in Shippable, I will still approve them and we have a section in conf.py to put weird failing links in that actually work.

We can't be linking to wiki.nginx.org. Because at some point that will go away and be replaced by your redirect engine causing lots of linkcheck failures from 301s.

LinuxJedi added a commit that referenced this pull request Jul 21, 2015
@LinuxJedi LinuxJedi merged commit 58186f3 into nginxinc:master Jul 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants