-
Notifications
You must be signed in to change notification settings - Fork 141
chore: run CI with Python 3.13 #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @himkt I see tests for 3.13 are failing in CI. Did you get this to run locally? Just wondering if I should attempt building the package locally for Python 3.13 until a new version lands on PyPI. |
Yeah, tests succeeded on the local environment with Python 3.13... Currently I do not have any problem in nglview with Python 3.13 but at the same time I still have no clue about this problem. |
|
Identified the root cause and scope of this problem. Core dump happens on pytraj API call inside Therefore, users using nglview with Python 3.13 and pytraj will encounter the error (cc. @ecederstrand). And I think I'm not sure it is the nglview specific problem. Although I'll create an environment to prepare all packages using conda later, this is the report at this time. @hainm Do you have any idea for this problem inside pytraj? I'm wondering how I should work on this problem (e.g. merge this PR with skipping pytraj call on Python 3.13, or keeping not to run CI on Python 3.13 until pytraj problem is fixed, ...) |
|
Hi @himkt It's up to you. I am fine with either. |
|
Thanks @himkt very much for all the work. I will make a release soon. may be today. |
@himkt no need. I will do this since I was the one making pytraj. Thanks. |
(I noticed that during pytest investigation, and I was so amazed by your contributions to computational chemistry) Thank you so much! |
|
Thank you. Just felt/feel good when doing that. |
|
@himkt I have made 4.0 release in pypi. |
🔗. #1162 (comment)