Skip to content

fix(requests): update request results stuck 'fetching' (#542)#543

Merged
NetanelBasal merged 1 commit intongneat:masterfrom
citruspress:master
Mar 5, 2026
Merged

fix(requests): update request results stuck 'fetching' (#542)#543
NetanelBasal merged 1 commit intongneat:masterfrom
citruspress:master

Conversation

@citruspress
Copy link
Copy Markdown
Contributor

@citruspress citruspress commented Feb 2, 2026

Request states are now updated using rxjs finalize() when still status: 'fetching'. This fixes an issue where observables were cached after immediately cancelling them.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #542

What is the new behavior?

If request results still have the status 'fetching' when finalizing, the status is set back to 'idle' and loading, success and error are all set to false.

Does this PR introduce a breaking change?

[ ] Yes
[x] No (Not that I'm aware of)

Other information

If we misunderstood something when using elf, we'd be happy to change things on our end.

Request states are now updated using rxjs finalize() when still status: 'fetching'.
This fixes an issue where observables were cached after immediately cancelling them.
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@jacobg213
Copy link
Copy Markdown

Just hit the exact same issue. Would be great to get this fix in!

@NetanelBasal NetanelBasal merged commit 7015d6e into ngneat:master Mar 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants