Skip to content

Added support for floating point units for ARM embedded targets #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngraf3255 merged 2 commits into from
Oct 28, 2025
Merged

Added support for floating point units for ARM embedded targets #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e74015d
Made changes to support floating point embedded units
ngraf3255 Oct 28, 2025
328e5b8
Marked param as optional
ngraf3255 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rust/platform/triple_mappings.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ SUPPORTED_T2_PLATFORM_TRIPLES = {
"riscv64gc-unknown-linux-gnu": _support(std = True, host_tools = False),
"riscv64gc-unknown-none-elf": _support(std = True, host_tools = False),
"s390x-unknown-linux-gnu": _support(std = True, host_tools = True),
"thumbv6m-none-eabi": _support(std = True, host_tools = False),
"thumbv7em-none-eabi": _support(std = True, host_tools = False),
"thumbv7em-none-eabihf": _support(std = True, host_tools = False),
"thumbv8m.main-none-eabi": _support(std = True, host_tools = False),
"wasm32-unknown-emscripten": _support(std = True, host_tools = False),
"wasm32-unknown-unknown": _support(std = True, host_tools = False),
Expand Down Expand Up @@ -282,12 +284,13 @@ _SYSTEM_TO_STDLIB_LINKFLAGS = {
"windows": ["advapi32.lib", "ws2_32.lib", "userenv.lib", "Bcrypt.lib"],
}

def cpu_arch_to_constraints(cpu_arch, *, system = None):
def cpu_arch_to_constraints(cpu_arch, *, system = None, abi = None):
"""Returns a list of constraint values which represents a triple's CPU.

Args:
cpu_arch (str): The architecture to match constraints for
system (str, optional): The system for the associated ABI value.
abi (str, optional): The application binary interface required for the target platform

Returns:
List: A list of labels to constraint values
Expand All @@ -298,7 +301,7 @@ def cpu_arch_to_constraints(cpu_arch, *, system = None):
plat_suffix = _CPU_ARCH_TO_BUILTIN_PLAT_SUFFIX[cpu_arch]

# Patch armv7e-m to mf if hardfloat abi is selected
if plat_suffix == "armv7e-m" and system == "eabihf":
if plat_suffix == "armv7e-m" and (system == "eabihf" or abi == "eabihf"):
plat_suffix = "armv7e-mf"

return ["@platforms//cpu:{}".format(plat_suffix)]
Expand Down Expand Up @@ -462,6 +465,7 @@ def triple_to_constraint_set(target_triple):
constraint_set += cpu_arch_to_constraints(
triple_struct.arch,
system = triple_struct.system,
abi = triple_struct.abi,
)
constraint_set += vendor_to_constraints(triple_struct.vendor)
constraint_set += system_to_constraints(triple_struct.system)
Expand Down