Eye of Ayak Fix #96
Closed
Eye of Ayak Fix #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magic animations fixes from
ngraves95
reviewed
Sep 3, 2025
|
|
||
| AnimationData fromId = AnimationData.fromId(animationId); | ||
| if (fromId == AnimationData.RANGED_BLOWPIPE || fromId == AnimationData.RANGED_BLAZING_BLOWPIPE) | ||
| if (fromId == AnimationData.RANGED_BLOWPIPE || fromId == AnimationData.RANGED_BLAZING_BLOWPIPE || fromId == AnimationData.MAGIC_EYE_OF_AYAK || fromId == AnimationData.MAGIC_EYE_OF_AYAK_SPEC) |
Owner
There was a problem hiding this comment.
Now that we have more than one problematic animation, maybe its time to put it into a set or other container instead of in the if statement
Owner
|
Can you please fix up the commits to remove the merge commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that the Eye of Ayak is a weapon that fires rapidly, similar to the blowpipe, it was not registering attacks correctly. These changes fix the above issue.
@ngraves95