fix(ngrok): use ReconcileStatus for CloudEndpoint IsNotFound handling…#799
Merged
Conversation
… — bug 2.4 CloudEndpoint bypassed ReconcileStatus and silently discarded the status update error when handling ngrok.IsNotFound. Now follows the standard pattern used by IPPolicy and other controllers. Bug-ID: 2.4 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
area/controller
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 51.80% 51.50% -0.30%
==========================================
Files 101 101
Lines 11188 11189 +1
==========================================
- Hits 5796 5763 -33
- Misses 4976 5003 +27
- Partials 416 423 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonstacks
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: K8SOP-240
What
CloudEndpoint bypassed
ReconcileStatusand silently discarded the status update error when handlingngrok.IsNotFound. This was inconsistent with every other controller (IPPolicy, Domain, AgentEndpoint) and skipped error wrapping, event recording, and the 10-second requeue-on-conflict logic.How
Replaced
_ = r.Client.Status().Update(ctx, clep)withr.controller.ReconcileStatus(ctx, clep, nil), matching the standard pattern. Also documented the status update pattern inspecs/controllers/status-updates.md.Breaking Changes
None