update the Rust SDK to use domains, not hostnames #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Bah. Missed some tests due to being too focused on just the |
Hostnames kept working for awhile because ngrok does have backcompat for it, hostnames don't go through codepaths that enable internal or kubernetes bindings. Fix that by cutting over to domains.
bmpngrok
force-pushed
the
bmps/domains-not-hostnames
branch
from
93316ab to
bbba73e
Compare
Contributor
Author
|
This PR is part of a stack of 2 bookmarks:
Created with jj-stack |
Alice-Lilith
approved these changes
Nov 10, 2025
Abdiramen
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostnames kept working for awhile because ngrok does have backcompat for it, hostnames don't go through codepaths that enable internal or kubernetes bindings. Fix that by cutting over to domains.