Skip to content

Commit faf6491

Browse files
fix(eslint-plugin): add type-checked configs to legacy config (#5038)
1 parent a53de86 commit faf6491

File tree

11 files changed

+32
-26
lines changed

11 files changed

+32
-26
lines changed

modules/eslint-plugin/scripts/generate-config.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { NgRxRule } from '../src/rule-creator';
1515
rule.meta.docs?.requiresTypeChecking === true;
1616

1717
writeConfig('all', (rule) => !isTypeChecked(rule));
18-
writeConfig('allTypeChecked', (_rule) => true);
18+
writeConfig('all-type-checked', (_rule) => true);
1919

2020
writeConfig(
2121
'store',
@@ -26,7 +26,7 @@ import { NgRxRule } from '../src/rule-creator';
2626
'effects',
2727
(rule) => isModule(rule, 'effects') && !isTypeChecked(rule)
2828
);
29-
writeConfig('effectsTypeChecked', (rule) => isModule(rule, 'effects'));
29+
writeConfig('effects-type-checked', (rule) => isModule(rule, 'effects'));
3030

3131
writeConfig(
3232
'component-store',
@@ -42,19 +42,19 @@ import { NgRxRule } from '../src/rule-creator';
4242
'signals',
4343
(rule) => isModule(rule, 'signals') && !isTypeChecked(rule)
4444
);
45-
writeConfig('signalsTypeChecked', (rule) => isModule(rule, 'signals'));
45+
writeConfig('signals-type-checked', (rule) => isModule(rule, 'signals'));
4646

4747
async function writeConfig(
4848
configName:
4949
| 'all'
50-
| 'allTypeChecked'
50+
| 'all-type-checked'
5151
| 'store'
5252
| 'effects'
53-
| 'effectsTypeChecked'
53+
| 'effects-type-checked'
5454
| 'component-store'
5555
| 'operators'
5656
| 'signals'
57-
| 'signalsTypeChecked',
57+
| 'signals-type-checked',
5858
predicate: (rule: NgRxRule) => boolean
5959
) {
6060
const rulesForConfig = Object.entries(rulesForGenerate).filter(

modules/eslint-plugin/spec/exported-rules.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('ESLint V9', () => {
3333
rules.length
3434
);
3535
});
36-
test('there is a difference between typed checke rules ', () => {
36+
test('there is a difference between typed checked rules ', () => {
3737
expect(
3838
Object.keys((configs.allTypeChecked[1] as any).rules).length
3939
).toBeGreaterThan(Object.keys((configs.all[1] as any).rules).length);

modules/eslint-plugin/src/configs/allTypeChecked.json renamed to modules/eslint-plugin/src/configs/all-type-checked.json

File renamed without changes.

modules/eslint-plugin/src/configs/allTypeChecked.ts renamed to modules/eslint-plugin/src/configs/all-type-checked.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default (
1919
},
2020
},
2121
{
22-
name: 'ngrx/allTypeChecked',
22+
name: 'ngrx/all-type-checked',
2323
languageOptions: {
2424
parser,
2525
},

modules/eslint-plugin/src/configs/effectsTypeChecked.json renamed to modules/eslint-plugin/src/configs/effects-type-checked.json

File renamed without changes.

modules/eslint-plugin/src/configs/effectsTypeChecked.ts renamed to modules/eslint-plugin/src/configs/effects-type-checked.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default (
1919
},
2020
},
2121
{
22-
name: 'ngrx/effectsTypeChecked',
22+
name: 'ngrx/effects-type-checked',
2323
languageOptions: {
2424
parser,
2525
},

modules/eslint-plugin/src/configs/signalsTypeChecked.json renamed to modules/eslint-plugin/src/configs/signals-type-checked.json

File renamed without changes.

modules/eslint-plugin/src/configs/signalsTypeChecked.ts renamed to modules/eslint-plugin/src/configs/signals-type-checked.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default (
1919
},
2020
},
2121
{
22-
name: 'ngrx/signalsTypeChecked',
22+
name: 'ngrx/signals-type-checked',
2323
languageOptions: {
2424
parser,
2525
},

modules/eslint-plugin/src/index.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,25 @@
11
import { rules } from './rules';
22
import all from './configs/all.json';
3+
import allTypeChecked from './configs/all-type-checked';
34
import componentStore from './configs/component-store.json';
45
import effects from './configs/effects.json';
6+
import effectsTypeChecked from './configs/effects-type-checked';
57
import store from './configs/store.json';
68
import operators from './configs/operators.json';
79
import signals from './configs/signals.json';
10+
import signalsTypeChecked from './configs/signals-type-checked';
811

912
export = {
1013
configs: {
1114
all,
15+
'all-type-checked': allTypeChecked,
1216
'component-store': componentStore,
1317
effects: effects,
18+
'effects-type-checked': effectsTypeChecked,
1419
store: store,
1520
operators: operators,
1621
signals: signals,
22+
'signals-type-checked': signalsTypeChecked,
1723
},
1824
rules,
1925
};

modules/eslint-plugin/v9/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ import {
66
version as packageVersion,
77
} from '../package.json';
88
import all from '../src/configs/all';
9+
import allTypeChecked from '../src/configs/all-type-checked';
910
import store from '../src/configs/store';
1011
import effects from '../src/configs/effects';
12+
import effectsTypeChecked from '../src/configs/effects-type-checked';
1113
import componentStore from '../src/configs/component-store';
1214
import operators from '../src/configs/operators';
1315
import signals from '../src/configs/signals';
14-
import allTypeChecked from '../src/configs/allTypeChecked';
15-
import effectsTypeChecked from '../src/configs/effectsTypeChecked';
16-
import signalsTypeChecked from '../src/configs/signalsTypeChecked';
16+
import signalsTypeChecked from '../src/configs/signals-type-checked';
1717

1818
const meta = { name: packageName, version: packageVersion };
1919

0 commit comments

Comments
 (0)