Skip to content

docs(entity): fix selectedUserId type#3017

Merged
brandonroberts merged 1 commit intongrx:masterfrom
markostanimirovic:selected-user-id
May 11, 2021
Merged

docs(entity): fix selectedUserId type#3017
brandonroberts merged 1 commit intongrx:masterfrom
markostanimirovic:selected-user-id

Conversation

@markostanimirovic
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

In @ngrx/entity examples, interface User has id property which is of type string, but selectedUserId has type number or number | null instead of string | null.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngrxbot
Copy link
Copy Markdown
Collaborator

ngrxbot commented May 10, 2021

Preview docs changes for 417ddef at https://previews.ngrx.io/pr3017-417ddefc/

@brandonroberts brandonroberts merged commit 9640dbc into ngrx:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants