-
Notifications
You must be signed in to change notification settings - Fork 143
StreamBrowserDialog rework #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
azonenberg
merged 53 commits into
ngscopeclient:master
from
fredzo:stream-browser-dialog-update
Jan 14, 2026
Merged
StreamBrowserDialog rework #941
azonenberg
merged 53 commits into
ngscopeclient:master
from
fredzo:stream-browser-dialog-update
Jan 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rOnOffToggleEXT methods.
…rOnOffToggle methods.
Added 7 segment display for DMM and PSU values in StreamBrowserDialog.
…ble borders around SteamBrowserDialog blocks (e.g. channel properties).
Fixed RBW handling in StreamBrowserDialog.
…cess channel property dialog.
Added properties dialog button to dmm and oscilloscope.
Refactoired prperty edit method names.
First step to channel propoeries editing in StreamBrowserDialog.
…nd invert settings. Added digital threshold setting.
…nodes by default.
This was referenced Jan 10, 2026
Updated copyright notice. Fixed shared pointer creation in ChannelPropertyDialog.
Removed FunctionGeneratorDialog (replaced by AWG node in StreamBrowserDialog).
First step to removing MultimeterDialog.
…), 7 segment display or proportional font).
… for property display.
Made all explicit apply property inputs use the new design.
Contributor
Author
|
@azonenberg I'm done with the requested changes:
I tried not to break anything with the ExplicitApply refactor, but could not test the following dialogs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
As discussed, here is my work on StreamBrowserDialog.
Main changes are:
Editable properties:

Property blocks + channel/instrument dialog button:

Oscilloscope / AWG nodes:

DMM/PSU nodes:
