Skip to content

Conversation

@fredzo
Copy link
Contributor

@fredzo fredzo commented Jan 10, 2026

Hi Andrew,

As discussed, here is my work on StreamBrowserDialog.
Main changes are:

  • Global behaviour:
    • Properties shown in StreamBrowser are editable when possible
    • For numeric values, we can have explicit or implicit apply like in instrument/channel property dialogs
    • For explicit apply, the "apply" button is represented as small green button with "⏎" character
    • Property blocks can be displayed with a border (this is configurable)
    • A small "+" button is added at the top right corner of Property blocks to open the channel/instrument property dialog
  • Oscilloscope node:
    • Added channel properties (Attenuation, Coupling, Bandwidth Limit, Invert, Offset, Range and Digital Threshold)
    • When available, digital channels are gathered in digital banks to reduce clutter
  • AWG node:
    • Added shape preview
    • Added duty cycle property
  • DMM node added
  • For both DMM node and PSU nodes, voltage and current value can be displayed using 7 segment-like display (this is configurable)
  • Session cache for instrument properties is refreshed when FlushConfigCache button is used

Editable properties:
ngscopeclient_Zq2i9lDnHq

Property blocks + channel/instrument dialog button:
ngscopeclient_jtD49MbZr9

Oscilloscope / AWG nodes:
ngscopeclient_xUY3jk9Gsp

DMM/PSU nodes:
ngscopeclient_K28FKZfI41

fredzo and others added 30 commits January 2, 2026 19:41
Added 7 segment display for DMM and PSU values in StreamBrowserDialog.
…ble borders around SteamBrowserDialog blocks (e.g. channel properties).
Fixed RBW handling in StreamBrowserDialog.
Added properties dialog button to dmm and oscilloscope.
Refactoired prperty edit method names.
First step to channel propoeries editing in StreamBrowserDialog.
…nd invert settings.

Added digital threshold setting.
@fredzo
Copy link
Contributor Author

fredzo commented Jan 12, 2026

@azonenberg I'm done with the requested changes:

  • Updated Copyright notice
  • Fixed typos
  • Fixed shared pointer creation
  • Added Rise and Fall time to AWG node in StreamBrowserDialog
  • Removed Multimeter and FunctionGenerator dialogs
  • Merged m_oscilloscopes and m_oscilloscopeStates in Session class
  • Made DMM/PSU value display option a 3 option choice:
    • Console font (default)
    • 7 segment display
    • Default font
  • Changed UTF8 strings to actual UTF8 symbols
  • Refactored property editing methods from StreamBrowserDialog class to Dialog class + replaced "ExplcitApply" methods with new apply button design

I tried not to break anything with the ExplicitApply refactor, but could not test the following dialogs:

  • RFGeneratorDialog
  • LoadDialog
  • DigitalOutputChannelDialog
  • DigitalIOChannelDialog

@azonenberg azonenberg merged commit 85e6384 into ngscopeclient:master Jan 14, 2026
23 checks passed
@fredzo fredzo deleted the stream-browser-dialog-update branch January 14, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants