My tweaks to F#.Formatting generation#1
Open
baronfel wants to merge 2 commits into
Open
Conversation
baronfel
commented
May 28, 2024
| <Title>FsAutoComplete</Title> | ||
| <Product>FsAutoComplete</Product> | ||
| <PackageLicenseExpression Condition=" '$(PackAsTool)' != 'true' ">Apache-2.0</PackageLicenseExpression> | ||
| <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> |
Author
There was a problem hiding this comment.
All of our stuff in this repo is Apache, so need need for the conditional
| <!-- Only the tool package is packable --> | ||
| <IsPackable>false</IsPackable> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <FsDocsLicenseLink>https://www.apache.org/licenses/LICENSE-2.0</FsDocsLicenseLink> |
Comment on lines
+17
to
+21
| <PropertyGroup Label="FsDocsProperties"> | ||
| <!-- FSharp.Formatting has custom properties, but these should mostly be set from more | ||
| standard packaging properties IMO. --> | ||
| <RepositoryUrl Condition="'$(RepositoryUrl)' == '' and '$(PublishRepositoryUrl)' == 'true'">$(PrivateRepositoryUrl)</RepositoryUrl> | ||
| <FsDocsReleaseNotesLink>$(RepositoryUrl)/blob/main/CHANGELOG.md</FsDocsReleaseNotesLink> |
Author
There was a problem hiding this comment.
This is partly what I was talking about on my comment to your PR - this should be automatable to some degree with already-existing data, it just seems like there's a gap in the SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.