Merged
Conversation
Closed
amaiaita
previously requested changes
Dec 22, 2023
Collaborator
amaiaita
left a comment
There was a problem hiding this comment.
If the tags and images (which I'm working on) is something we want to make work separately to this PR then feel free to merge! otherwise the tags need fixing :) looks good otherwise!
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Yes, the tags are due to my own lack of skill!! that's the best I could do - I made ./overrides/main.html take the tags from the metadata for the page... and then I didn't know how to do anything fancy with them!
We can make that another ticket :)
As she said - we can move that to another ticket - so it's approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
❓What: Added the existing SKunkworks pages (https://nhsx.github.io/skunkworks/data-lens) and make them work. closes #18
🧠Why?: They have merged with our team in the new NHSE.
👨💻How?: Dragged and dropped the pages, then made some slight edits so the images etc would work normally. This also needed me to edit some other bits of the site, such as the overrides, so it would pull stuff from the page metadata.
I haven't done a comprehensive check of the page contents - that's for the teams to do later.
Checklist:
Have checked for the following:
mkdocs serve.Where it was tested