Skip to content

Sh skunkworks#25

Merged
SamHollings merged 2 commits intomainfrom
sh_skunkworks
Dec 22, 2023
Merged

Sh skunkworks#25
SamHollings merged 2 commits intomainfrom
sh_skunkworks

Conversation

@SamHollings
Copy link
Collaborator

@SamHollings SamHollings commented Dec 19, 2023

Description

What: Added the existing SKunkworks pages (https://nhsx.github.io/skunkworks/data-lens) and make them work. closes #18

🧠Why?: They have merged with our team in the new NHSE.

👨‍💻How?: Dragged and dropped the pages, then made some slight edits so the images etc would work normally. This also needed me to edit some other bits of the site, such as the overrides, so it would pull stuff from the page metadata.
I haven't done a comprehensive check of the page contents - that's for the teams to do later.

Checklist:

Have checked for the following:

  • The website still builds correctly, and you can view it using mkdocs serve.
  • There are no new "warnings" from mkdocs
  • Does your page follow the page template (or here in Markdown)? (need to make a new one specific to NHSE Data Science)
  • Spelling errors
  • Consistent capitalization
  • Consistent numbers
  • Material features incorrectly implemented: search for code blocks and markers (e.g. !!!).
  • Code snippets don't work
  • Images not working
  • Links not working

Where it was tested

  • Github Codespaces - 2-core, 4GB RAM, 32GB hard drive
  • devcontainer.json describes further settings

@SamHollings SamHollings requested a review from amaiaita December 19, 2023 15:42
@SamHollings SamHollings added this to the Basic website milestone Dec 19, 2023
@SamHollings SamHollings mentioned this pull request Dec 19, 2023
Copy link
Collaborator

@amaiaita amaiaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tags and images (which I'm working on) is something we want to make work separately to this PR then feel free to merge! otherwise the tags need fixing :) looks good otherwise!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tags in all of these pages are visible on the page in a weird format - i assume that wasnt the intention?
Screenshot 2023-12-22 at 08 13 34

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tags are due to my own lack of skill!! that's the best I could do - I made ./overrides/main.html take the tags from the metadata for the page... and then I didn't know how to do anything fancy with them!

We can make that another ticket :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made an issue #28

@SamHollings SamHollings dismissed amaiaita’s stale review December 22, 2023 09:52

As she said - we can move that to another ticket - so it's approved.

@SamHollings SamHollings merged commit 87e672d into main Dec 22, 2023
@SamHollings SamHollings deleted the sh_skunkworks branch February 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add skunkworks pages

2 participants