Recreated changes for the #51 - Cyclic Dependencies#165
Open
neilfenstein wants to merge 1 commit into
Open
Conversation
Moved Is Root actor loaded VI from Message Maker Library to AFPP Shared library.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved Is Root actor loaded VI from Message Maker Library to AFPP Shared library.
GitHub Issue for the Pull Request
Link to the relevant GitHub issue
GitHub Discussions Related to this Pull Request
List any GitHub discussion links related to this PR
Checklists
Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.
Summary of Changes
I have made the changes that remove the cyclic dependencies in Add Actor and Add Actor Interfaces Libraries.
Moved the VI named "Root Actor is Loaded.vi" from Message Maker Library to AFPP Shared library.
Reason for Change
Issue 51 rework request.
Visual Aids
Include any visual aids that would help the reviewer gain additional context.
Additional Information
Include any further details that may assist the reviewer in understanding the context of this PR.
Testing
Manual Tests
Manually added the Add Actor library to a empty project and confirmed the removal of dependency.