Skip to content

Add Ok fv attribute ignores to angular eslint #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rajsite wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Ok fv attribute ignores to angular eslint #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db80a0
fv attribute list config
rajsite May 11, 2026
364fdd1
Change files
rajsite May 11, 2026
a6adb4b
fix import
rajsite May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@

Copy link
Copy Markdown
Member Author

@rajsite rajsite May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started some offline discussion with @jattasNI if we want to track this in styleguide packages.

Copy link
Copy Markdown
Member Author

@rajsite rajsite May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related, we should probably have the selectors be narrowly scoped, i.e. ok-fv-card[interaction-mode]

Copy link
Copy Markdown
Member Author

@rajsite rajsite May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brainstorming, other potential locations could be an @ni-labs package in this repo or in a separate repo

# These owners will be the default owners for everything in the repo.
* @jattasNI @rajsite

# Specific content owners
/**/fv/** @jattasNI @fredvisser

# Change files don't need explicit reviewers
/change
7 changes: 7 additions & 0 deletions change/@ni-eslint-config-angular-0fb9c127-1ff4-4c09-8790-86ea0527226c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fv attribute list config",
"packageName": "@ni/eslint-config-angular",
"email": "1588923+rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/eslint-config-angular/lib/ok/fv/ignore-attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// Fv angular attributes that SHOULD NOT be localized in production (i.e. enums)

export const fvIgnoreAttributes = [
];
7 changes: 7 additions & 0 deletions packages/eslint-config-angular/lib/template-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
// CSS selector style element[attribute] ignore entries
// which can be used to scope attribute ignores to specific
// elements.

import { fvIgnoreAttributes } from './ok/fv/ignore-attributes.js';

const ignoreAttributeSets = {
web: [
'accept',
Expand Down Expand Up @@ -111,6 +114,10 @@ const ignoreAttributeSets = {
// chat
'message-type'
],
ok: [
// fv
...fvIgnoreAttributes
],
systemlink: [
// gainsights telemetry
'data-telemetry',
Expand Down
Loading