Skip to content

mmc: sdhci: Disable SD card clock before changing parameters #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gratian merged 1 commit into from
Apr 16, 2026
Merged

mmc: sdhci: Disable SD card clock before changing parameters #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions drivers/mmc/host/sdhci-pci-core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,8 +689,19 @@ static int intel_start_signal_voltage_switch(struct mmc_host *mmc,
return 0;
}

static void sdhci_intel_set_clock(struct sdhci_host *host, unsigned int clock)
{
u16 clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL);

/* Stop card clock separately to avoid glitches on clock line */
if (clk & SDHCI_CLOCK_CARD_EN)
sdhci_writew(host, clk & ~SDHCI_CLOCK_CARD_EN, SDHCI_CLOCK_CONTROL);

sdhci_set_clock(host, clock);
}

static const struct sdhci_ops sdhci_intel_byt_ops = {
.set_clock = sdhci_set_clock,
.set_clock = sdhci_intel_set_clock,
.set_power = sdhci_intel_set_power,
.enable_dma = sdhci_pci_enable_dma,
.set_bus_width = sdhci_set_bus_width,
Expand All @@ -700,7 +711,7 @@ static const struct sdhci_ops sdhci_intel_byt_ops = {
};

static const struct sdhci_ops sdhci_intel_glk_ops = {
.set_clock = sdhci_set_clock,
.set_clock = sdhci_intel_set_clock,
.set_power = sdhci_intel_set_power,
.enable_dma = sdhci_pci_enable_dma,
.set_bus_width = sdhci_set_bus_width,
Expand Down
Loading