Update repo for changes in measurement.proto#100
Merged
Conversation
dixonjoel
requested review from
bkeryan,
csjall,
jonlugoatx,
mshafer-NI and
nstokes-nati
as code owners
jonlugoatx
approved these changes
Oct 13, 2022
csjall
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Recent changes to measurement.proto made the user_interface_details of the metadata a repeated field of UserInterfaceDetails. These changes update the Python repo to take the ui_file_path specified in the service and put it as a single value in the UserInterfaceDetails
Why should this Pull Request be merged?
Keep up to date with the .proto file. Restore functionality of the Python examples.
What testing has been done?
Testing is not done yet. I'm creating this PR to see how many of the checks will pass. Tests are passing locally.