Skip to content

Remove ui-file-type and attributes#101

Merged
dixonjoel merged 6 commits intomainfrom
users/jdixon/remove-ui-file-type
Oct 14, 2022
Merged

Remove ui-file-type and attributes#101
dixonjoel merged 6 commits intomainfrom
users/jdixon/remove-ui-file-type

Conversation

@dixonjoel
Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Remove the ui-file-type, which was an enum with LabVIEW and MeasurementUI from the python repo. This is no longer used and the file path extension is used to decide what type of UI is used.

Why should this Pull Request be merged?

Follow changes in the ASW repo.

What testing has been done?

Ran automated tests locally

Comment thread README.md Outdated
Comment thread ni_measurement_service/measurement/info.py
@dixonjoel
Copy link
Copy Markdown
Collaborator Author

@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?

@bkeryan
Copy link
Copy Markdown
Collaborator

bkeryan commented Oct 14, 2022

@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?

Try urllib.request.url2pathname():
https://stackoverflow.com/questions/43911052/urlparse-on-a-windows-file-scheme-uri-leaves-extra-slash-at-start

@dixonjoel
Copy link
Copy Markdown
Collaborator Author

@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?

Try urllib.request.url2pathname(): https://stackoverflow.com/questions/43911052/urlparse-on-a-windows-file-scheme-uri-leaves-extra-slash-at-start

That seems to work, thanks. Hopefully will pass on linux too.

@dixonjoel dixonjoel merged commit c77fa40 into main Oct 14, 2022
@dixonjoel dixonjoel deleted the users/jdixon/remove-ui-file-type branch October 14, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants