You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the ui-file-type, which was an enum with LabVIEW and MeasurementUI from the python repo. This is no longer used and the file path extension is used to decide what type of UI is used.
@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?
@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?
@bkeryan my changes in test_grpc_service.py fail on ubuntu - it's trying to strip off the leading '/', which apparently is needed there... thoughts on how to do that in an os-independent way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Remove the ui-file-type, which was an enum with LabVIEW and MeasurementUI from the python repo. This is no longer used and the file path extension is used to decide what type of UI is used.
Why should this Pull Request be merged?
Follow changes in the ASW repo.
What testing has been done?
Ran automated tests locally