MeasurementService: Use a context manager to simplify ctrl-C handling#110
Merged
MeasurementService: Use a context manager to simplify ctrl-C handling#110
Conversation
bkeryan
requested review from
csjall,
dixonjoel,
jonlugoatx,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
approved these changes
Oct 26, 2022
csjall
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Make
MeasurementServiceimplement the context manager protocol so that clients can usewith measurement_service.host_service():to clean up automatically.Remove Win32-specific ctrl-C handling. A with-statement does the right thing when Python raises
KeyboardInterrupt.Why should this Pull Request be merged?
This partially fixes #38 by removing Win32-specific cleanup code.
What testing has been done?
Manually tested
sample_measurement: