service: Enable type checking for tracelogging#1123
Merged
Conversation
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
Contributor
bkeryan
commented
May 5, 2025
bkeryan
commented
May 5, 2025
This reverts commit 8215a0e.
…hints, but only create a provider on Windows
dixonjoel
approved these changes
May 6, 2025
bkeryan
added a commit
that referenced
this pull request
Jun 23, 2025
* service: Remove ignore_missing_imports for traceloggingdynamic * service: Update traceloggingdynamic in poetry.lock * service: Fix _tracelogging typing bugs * service: Only try to import traceloggingdynamic on Windows * service: Install traceloggingdynamic as a dev dependency on Linux for type checking * service: Update poetry.lock * Revert "service: Only try to import traceloggingdynamic on Windows" This reverts commit 8215a0e. * service: Try to import traceloggingdynamic on all platforms for type hints, but only create a provider on Windows * service: Import traceloggingdynamic on Windows and when type checking (cherry picked from commit 45f53e6)
1 task
bkeryan
added a commit
that referenced
this pull request
Jun 24, 2025
* service: Remove ignore_missing_imports for traceloggingdynamic * service: Update traceloggingdynamic in poetry.lock * service: Fix _tracelogging typing bugs * service: Only try to import traceloggingdynamic on Windows * service: Install traceloggingdynamic as a dev dependency on Linux for type checking * service: Update poetry.lock * Revert "service: Only try to import traceloggingdynamic on Windows" This reverts commit 8215a0e. * service: Try to import traceloggingdynamic on all platforms for type hints, but only create a provider on Windows * service: Import traceloggingdynamic on Windows and when type checking (cherry picked from commit 45f53e6)
bkeryan
added a commit
that referenced
this pull request
Jun 24, 2025
service: Enable type checking for tracelogging (#1123) * service: Remove ignore_missing_imports for traceloggingdynamic * service: Update traceloggingdynamic in poetry.lock * service: Fix _tracelogging typing bugs * service: Only try to import traceloggingdynamic on Windows * service: Install traceloggingdynamic as a dev dependency on Linux for type checking * service: Update poetry.lock * Revert "service: Only try to import traceloggingdynamic on Windows" This reverts commit 8215a0e. * service: Try to import traceloggingdynamic on all platforms for type hints, but only create a provider on Windows * service: Import traceloggingdynamic on Windows and when type checking (cherry picked from commit 45f53e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update the
traceloggingdynamicpackage inpoetry.lock.Remove
ignore_missing_importsfortraceloggingdynamic.Fix a couple of typing errors in the
_traceloggingsubmodule.Why should this Pull Request be merged?
I contributed a change to add a
py.typedmarker file to thetraceloggingdynamicpackage and it has been published to PyPI: microsoft/tracelogging#74What testing has been done?
Ran
poetry run nps lintandpoetry run mypy