Skip to content

Updated examples to use NI gRPC Device remoting by default#140

Merged
bkeryan merged 2 commits intomainfrom
users/tkrebes/grpc-device-default
Dec 6, 2022
Merged

Updated examples to use NI gRPC Device remoting by default#140
bkeryan merged 2 commits intomainfrom
users/tkrebes/grpc-device-default

Conversation

@tkrebes
Copy link
Copy Markdown
Contributor

@tkrebes tkrebes commented Dec 6, 2022

What does this Pull Request accomplish?

  • Updates instructions for using prerelease dependencies
  • Updates examples to use NI gRPC Device by default

Why should this Pull Request be merged?

Simplifies the user experience of using examples in NI TestStand.

What testing has been done?

Ran an example. Also, checked the command line help:

> poetry run python .\measurement.py --help
Usage: measurement.py [OPTIONS]

  Source and measure a DC voltage with an NI SMU.

Options:
  -v, --verbose                   Enable verbose logging. Repeat to increase
                                  verbosity.
  --use-grpc-device / --no-use-grpc-device
                                  Use the NI gRPC Device Server.
  --grpc-device-address TEXT      NI gRPC Device Server address (e.g.
                                  localhost:31763). If unspecified, use the
                                  discovery service to resolve the address.
  --help                          Show this message and exit.

Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In a separate PR, I think we should also upgrade to Poetry 1.2 and uncommit the nimi-python dev-dependency for now, so that these examples work out-of-the-box.

(Assuming that Poetry 1.2 doesn't cause unexpected problems.)

@bkeryan bkeryan merged commit d157faf into main Dec 6, 2022
@dixonjoel dixonjoel deleted the users/tkrebes/grpc-device-default branch December 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants