Skip to content

ni-measurement-service: Update package descriptions and push nimg version updates to main#150

Merged
bkeryan merged 5 commits intomainfrom
users/bkeryan/update-version
Dec 7, 2022
Merged

ni-measurement-service: Update package descriptions and push nimg version updates to main#150
bkeryan merged 5 commits intomainfrom
users/bkeryan/update-version

Conversation

@bkeryan
Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan commented Dec 7, 2022

What does this Pull Request accomplish?

Update nims description to "MeasurementLink Support for Python".
Update nimg description to "MeasurementLink Code Generator for Python".
Add CasperWA/push-protected to Publish_NIMG.yml so that the package version updates "stick".

Why should this Pull Request be merged?

Preparation for new release.

What testing has been done?

None

Copy link
Copy Markdown
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we should make a corresponding change in ni-measurement-generator.

Also, I remember some logic in the .github actions that attempted to update this version automatically when a release is created. As I remember it, this was working so that we'd get an updated version that was equivalent for ni-measurement-service and ni-measurement-generator, but it would only maybe write back and commit to git this ni-measurement-service version.

So maybe we can get that mechanism working for both and not have to update this manually. I guess we'd still have to do it though for major / minor versions.

@dixonjoel
Copy link
Copy Markdown
Collaborator

It seems like we should make a corresponding change in ni-measurement-generator.

Also, I remember some logic in the .github actions that attempted to update this version automatically when a release is created. As I remember it, this was working so that we'd get an updated version that was equivalent for ni-measurement-service and ni-measurement-generator, but it would only maybe write back and commit to git this ni-measurement-service version.

So maybe we can get that mechanism working for both and not have to update this manually. I guess we'd still have to do it though for major / minor versions.

This is the code I was referring to.

@bkeryan
Copy link
Copy Markdown
Collaborator Author

bkeryan commented Dec 7, 2022

It seems like we should make a corresponding change in ni-measurement-generator.

Also, I remember some logic in the .github actions that attempted to update this version automatically when a release is created. As I remember it, this was working so that we'd get an updated version that was equivalent for ni-measurement-service and ni-measurement-generator, but it would only maybe write back and commit to git this ni-measurement-service version.

So maybe we can get that mechanism working for both and not have to update this manually. I guess we'd still have to do it though for major / minor versions.

This suggests that I don't need to manually update the version number. The "new release" page on GitHub lets you specify the tag name, so you can choose whether to increment the major/minor/update version.

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

@mshafer-NI
Copy link
Copy Markdown
Collaborator

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

Here's where the push should happen: https://github.com/ni/measurement-services-python/blob/c658320d713c8f6de53a5ca9d5a16c95bcf00fe0/.github/workflows/Publish_NIMS.yml#L65

@bkeryan bkeryan changed the title ni-measurement-service: Update version and description for next release ni-measurement-service: Update package descriptions and push nimg version updates to main Dec 7, 2022
@bkeryan
Copy link
Copy Markdown
Collaborator Author

bkeryan commented Dec 7, 2022

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

Here's where the push should happen:

https://github.com/ni/measurement-services-python/blob/c658320d713c8f6de53a5ca9d5a16c95bcf00fe0/.github/workflows/Publish_NIMS.yml#L65

Both Publish_NIMG.yml and Publish_NIMS.yml use actions/checkout, so I wouldn't expect Publish_NIMS.yml's checkout to include Publish_NIMG.yml's unpushed commits. (However, I'm not 100% sure about this, and that's why I wonder if the past build failures were related.)

@bkeryan
Copy link
Copy Markdown
Collaborator Author

bkeryan commented Dec 7, 2022

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

Here's where the push should happen:
https://github.com/ni/measurement-services-python/blob/c658320d713c8f6de53a5ca9d5a16c95bcf00fe0/.github/workflows/Publish_NIMS.yml#L65

Both Publish_NIMG.yml and Publish_NIMS.yml use actions/checkout, so I wouldn't expect Publish_NIMS.yml's checkout to include Publish_NIMG.yml's unpushed commits. (However, I'm not 100% sure about this, and that's why I wonder if the past build failures were related.)

If Publish_NIMS.yml was seeing Publish_NIMG.yml's unpushed commits, then it would have pushed the update of nimg to 0.10.2.

@dixonjoel
Copy link
Copy Markdown
Collaborator

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

Yes, I believe that second commit of the version for ni-measurement-generator was problematic or at least I thought it was problematic so I took it out.

In reality, the publish process will use the tag regardless, so we don't really even have to care about this version or update it during the publish step. It's just a little confusing that it's out of date with what's published. So if we can get the two publish steps to both update the repo code, that's great. If we can't get that to work, we can either update these manually or just forget about it and don't care.

@bkeryan
Copy link
Copy Markdown
Collaborator Author

bkeryan commented Dec 7, 2022

The Publish_NIMG action commits the pyproject.toml update but it doesn't push this commit to main. I wonder if that's related to the problems we've had with previous builds.

Yes, I believe that second commit of the version for ni-measurement-generator was problematic or at least I thought it was problematic so I took it out.

In reality, the publish process will use the tag regardless, so we don't really even have to care about this version or update it during the publish step. It's just a little confusing that it's out of date with what's published. So if we can get the two publish steps to both update the repo code, that's great. If we can't get that to work, we can either update these manually or just forget about it and don't care.

@dixonjoel You removed the NIMG push on August 30 and you still had problems pushing NIMS to main on October 28:

https://github.com/ni/measurement-services-python/actions/runs/3346253359/jobs/5545677483

I'm going to try it with the NIMG push and the latest CasperWA/push-protected, and we'll see what happens.

@bkeryan bkeryan merged commit 31d6ffa into main Dec 7, 2022
@bkeryan bkeryan deleted the users/bkeryan/update-version branch December 7, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants