Conversation
dixonjoel
left a comment
There was a problem hiding this comment.
It seems like we should make a corresponding change in ni-measurement-generator.
Also, I remember some logic in the .github actions that attempted to update this version automatically when a release is created. As I remember it, this was working so that we'd get an updated version that was equivalent for ni-measurement-service and ni-measurement-generator, but it would only maybe write back and commit to git this ni-measurement-service version.
So maybe we can get that mechanism working for both and not have to update this manually. I guess we'd still have to do it though for major / minor versions.
This is the code I was referring to. |
This suggests that I don't need to manually update the version number. The "new release" page on GitHub lets you specify the tag name, so you can choose whether to increment the major/minor/update version. The Publish_NIMG action commits the |
Here's where the push should happen: https://github.com/ni/measurement-services-python/blob/c658320d713c8f6de53a5ca9d5a16c95bcf00fe0/.github/workflows/Publish_NIMS.yml#L65 |
Both Publish_NIMG.yml and Publish_NIMS.yml use |
If Publish_NIMS.yml was seeing Publish_NIMG.yml's unpushed commits, then it would have pushed the update of nimg to 0.10.2. |
Yes, I believe that second commit of the version for ni-measurement-generator was problematic or at least I thought it was problematic so I took it out. In reality, the publish process will use the tag regardless, so we don't really even have to care about this version or update it during the publish step. It's just a little confusing that it's out of date with what's published. So if we can get the two publish steps to both update the repo code, that's great. If we can't get that to work, we can either update these manually or just forget about it and don't care. |
@dixonjoel You removed the NIMG push on August 30 and you still had problems pushing NIMS to main on October 28: https://github.com/ni/measurement-services-python/actions/runs/3346253359/jobs/5545677483 I'm going to try it with the NIMG push and the latest CasperWA/push-protected, and we'll see what happens. |
What does this Pull Request accomplish?
Update nims description to "MeasurementLink Support for Python".
Update nimg description to "MeasurementLink Code Generator for Python".
Add
CasperWA/push-protectedtoPublish_NIMG.ymlso that the package version updates "stick".Why should this Pull Request be merged?
Preparation for new release.
What testing has been done?
None