Updated the dcpower LabVIEW example to have pinarray#156
Merged
Conversation
subash-suresh
requested review from
bkeryan,
csjall,
dixonjoel,
jonlugoatx,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
changed the title
Collaborator
|
Checking my understanding. This change is dependent on this commit to work correctly? |
dixonjoel
approved these changes
Dec 8, 2022
Collaborator
dixonjoel
left a comment
dixonjoel
left a comment
There was a problem hiding this comment.
Approve pending comments.
bkeryan
requested changes
Dec 8, 2022
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
I'm okay with allowing users to select multiple pins for output examples, as long as the example outputs the specified DC voltage on all of those pins.
Contributor
Author
Yes joel |
bkeryan
reviewed
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the
nidcpower_source_dc_voltage_with_labview_uiexample to have pin array control instead of a pin control to show pingroups and pins in the control.Why should this Pull Request be merged?
nidcpower_source_dc_voltage_with_labview_uiexample to have pin array control.What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.