Add instrument type for pin parameters in examples#168
Merged
Conversation
subash-suresh
requested review from
bkeryan,
csjall,
dixonjoel,
jonlugoatx,
mshafer-NI and
nstokes-nati
as code owners
subash-suresh
changed the title
dixonjoel
approved these changes
Dec 14, 2022
Collaborator
|
@subash-suresh Looks like you've got a failing check and need some .py linting changes. |
Contributor
Author
Yes, I have fixed them and updated the documentation for the instrument type parameter |
bkeryan
requested changes
Dec 14, 2022
Collaborator
|
|
bkeryan
reviewed
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the examples to have instrument type restrictions if applicable.
Why should this Pull Request be merged?
instrument_typeparameter documentation to tell more about the supported NI instrument types.What testing has been done?
Manually tested each of the example.