Skip to content

Add a script that installs examples#171

Merged
bkeryan merged 4 commits intomainfrom
users/bkeryan/install-examples
Dec 16, 2022
Merged

Add a script that installs examples#171
bkeryan merged 4 commits intomainfrom
users/bkeryan/install-examples

Conversation

@bkeryan
Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan commented Dec 15, 2022

What does this Pull Request accomplish?

Add a script that runs poetry install on all of the examples and installs them into C:\ProgramData.

Why should this Pull Request be merged?

I am sick of doing this manually.

What testing has been done?

Ran multiple times while developing script.

@bkeryan bkeryan changed the title Users/bkeryan/install examples Add a script that installs examples Dec 15, 2022
@bkeryan bkeryan requested a review from tkrebes December 15, 2022 22:16
@bkeryan
Copy link
Copy Markdown
Collaborator Author

bkeryan commented Dec 16, 2022

I discussed this offline with @mshafer-NI and he pointed out some similar code that does the venv stuff a bit differently. One minor improvement is using os.environ.copy() and passing the modified environment to subprocess.run(), though it currently doesn't make a difference.

@bkeryan bkeryan merged commit fcc8054 into main Dec 16, 2022
@bkeryan bkeryan deleted the users/bkeryan/install-examples branch December 16, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants