Conversation
typed-ast is end-of-life and does not support Python 3.11. Mypy only needs typed-ast with Python 3.7 and older, which MeasurementLink does not support.
bkeryan
requested review from
csjall,
dixonjoel and
jonlugoatx
as code owners
jonlugoatx
approved these changes
Dec 20, 2022
bkeryan
force-pushed
the
users/bkeryan/python-3.11
branch
from
0d48acc to
9e0981d
Compare
Collaborator
Author
|
In the PR workflow, I'm getting "poetry: command not found" errors on macOS. This may be related to Gr1N/setup-poetry#33 . @dixonjoel @mshafer-NI Do the runner images need to be updated for Python 3.11 support? |
dixonjoel
approved these changes
Dec 30, 2022
Collaborator
The comment thread on the issue says v8 of Gr1N has fixed this. We should try that version to see if it fixes this for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update PR pipeline to test with Python 3.11.
Remove
typed-astdependency.typed-astis end-of-life and does not support Python 3.11.mypyonly needstyped-astwith Python 3.7 and older, which MeasurementLink does not support.Why should this Pull Request be merged?
Allow customers to use Python 3.11.
Fixes #154
What testing has been done?
Ran unit tests.