Conversation
…ptions when calling wait_until_done. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
Collaborator
Many projects and Git tools don't like overly long commit subject lines. I guess GitHub is one of them. |
bkeryan
reviewed
Jan 18, 2023
dixonjoel
approved these changes
Jan 18, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
bkeryan
approved these changes
Jan 18, 2023
bkeryan
reviewed
Jan 18, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
dixonjoel
deleted the
users/cdelpire/catch-fgen-timeout-errors-in-example
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ptions when calling wait_until_done.
Signed-off-by: Chris Delpire chris.delpire@ni.com
What does this Pull Request accomplish?
With real hardware the FGEN example throws an exception when calling wait_until_done. This is expected and in other examples we are catching timeout exceptions and trying again until a cancellation occurs or the operation completes successfully. I have added a try/except to the FGEN example to do the same.
I tested with two different instruments and saw two different error codes, so I am checking for both.
Why should this Pull Request be merged?
Currently the FGEN example will not work with real hardware.
What testing has been done?
This was tested on a device with real FGEN devices attached.
AB#2272711