Conversation
…meout exceeded error. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
bkeryan
requested changes
Jan 20, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
bkeryan
approved these changes
Jan 20, 2023
dixonjoel
deleted the
users/cdelpire/fix-error-handling-in-dcpower-measurement-example
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Delpire chris.delpire@ni.com
What does this Pull Request accomplish?
nidcpower.DriverErrordoes not exist.It should beIt should benidcpower.Error.nidcpower.errors.DriverError. (Fixed fgen too)-1074097933(kErrorTimeoutExceeded).Fixed the error handling and added the additional error code check.
Why should this Pull Request be merged?
Current example does not support source delay with hardware.
What testing has been done?
Tested on a machine with an actual SMU device.