Conversation
…asurementLink. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
bkeryan,
csjall,
dixonjoel and
pbirkhol-ni
as code owners
pbirkhol-ni
suggested changes
Feb 10, 2023
Contributor
pbirkhol-ni
left a comment
pbirkhol-ni
left a comment
There was a problem hiding this comment.
I think you should resave these again once Jonathan's change has been submitted and cherry picked.
Contributor
Author
Yes that sounds good. I just wanted this up incase we decided not to cherry pick. |
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Contributor
Author
|
@pbirkhol-ni Updated with seq files saved in TS2021 SP1 and MeasurementLink 23.0 f902. |
bkeryan
approved these changes
Feb 13, 2023
pbirkhol-ni
approved these changes
Feb 13, 2023
dixonjoel
deleted the
users/cdelpire/update-seq-files-from-examples-to-latest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…asurementLink.
Signed-off-by: Chris Delpire chris.delpire@ni.com
What does this Pull Request accomplish?
Opened all example seq files in TestStand 2021 SP1, upgraded the types to the latest, and saved the file.
Why should this Pull Request be merged?
Customers opening the seq file in TestStand 2021 will see a dialog warning about a step type mismatch if we do not update them.
Unfortunately, they will still have this dialog with TestStand 2022.
What testing has been done?
Opened seq file in TestStand 2021 SP1 and did not see the dialog. It would be nice if someone could test this with TestStand 2021 (non-SP1 build).