Update Measurement Service Examples to include service Annotations #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpachecoNI
requested review from
bkeryan,
csjall,
dixonjoel and
pbirkhol-ni
as code owners
gpachecoNI
changed the title
dixonjoel
changed the title
1 task
dixonjoel
changed the title
gpachecoNI
force-pushed
the
users/gpacheco/AddServiceAnnotationToGenerator
branch
from
dea1d86 to
db26e6d
Compare
|
FYI, I created a releases/1.1 branch and updated main to version 1.2.0-dev0 in order to unblock these PRs. |
cumitche
reviewed
Jun 27, 2023
cumitche
reviewed
Jun 27, 2023
gpachecoNI
force-pushed
the
users/gpacheco/AddServiceAnnotationToGenerator
branch
from
db26e6d to
4cb83ef
Compare
gpachecoNI
changed the title
gpachecoNI
force-pushed
the
users/gpacheco/UpdateExamples
branch
from
0c37b50 to
980fe63
Compare
gpachecoNI
force-pushed
the
users/gpacheco/AddServiceAnnotationToGenerator
branch
from
4cb83ef to
62d90ec
Compare
gpachecoNI
force-pushed
the
users/gpacheco/UpdateExamples
branch
from
1249673 to
74fc3b1
Compare
bkeryan
approved these changes
Jun 29, 2023
examples/nidcpower_source_dc_voltage/NIDCPowerSourceDCVoltage.serviceconfig
Outdated
Show resolved
Hide resolved
gpachecoNI
force-pushed
the
users/gpacheco/UpdateExamples
branch
from
74fc3b1 to
24e45ac
Compare
dixonjoel
approved these changes
Jun 30, 2023
Base automatically changed from
users/gpacheco/AddServiceAnnotationToGenerator
to
main
June 30, 2023 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
TODO: Include high-level description of the changes in this pull request.
TODO: Justify why this contribution should be part of the project.
AB#2408764
What testing has been done?
Manually ran all examples.
TODO: Detail what testing has been done to ensure this submission meets requirements.