[releases/1.1] ni_measurementlink_service: Launch discovery service just-in-time before registering a measurement service#317
Merged
bkeryan merged 1 commit intoreleases/1.1from Jun 30, 2023
Conversation
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
1 task
dixonjoel
approved these changes
Jun 30, 2023
…ore registering a measurement service. (#290) * discovery_client: Launch discovery service just-in-time * discovery_client: add comments to functions * discovery_client: Fix lint errors. * discovery_client: Fix function docstring and type hint * discovery_client: Wait for key file existence and time out when 30 seconds elapse * discovery_client: Replace polling2 module with time module * discovery_client: Added service already running functionality * discovery_client: Refactor open method with write permission. Co-authored-by: Brad Keryan <brad.keryan@ni.com> --------- Co-authored-by: Brad Keryan <brad.keryan@ni.com> (cherry picked from commit 5af9b2f)
bkeryan
force-pushed
the
users/bkeryan/launch-discovery-service-jit-1.1
branch
from
07549f0 to
593ca34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
discovery_clientto ensure discovery service is started before measurement service is trying to register to it.Cherry picked from 5af9b2f
Why should this Pull Request be merged?
What testing has been done?