Fix pywintypes error during the launch of the discovery service after a fresh install of MeasurementLink #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…ttps://github.com/ni/measurement-services-python into users/sam/fix-discoveryservicelaunch-onfreshInstall
Tharun-Sundar
approved these changes
Sep 22, 2023
samchris007
force-pushed
the
users/sam/fix-discoveryservicelaunch-onfreshInstall
branch
from
5e8b73b to
75262fa
Compare
samchris007
requested review from
bkeryan,
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
Collaborator
|
If we wanted to reproduce this locally and test the fix without having to do a fresh install, would you recommend just deleting the 'Logs' or 'Discovery' folder in programdata? |
Contributor
Author
Yes, we can terminate any existing running discovery service, delete the Note: Running without any debuggers makes it more easily reproducible |
dixonjoel
reviewed
Sep 22, 2023
dixonjoel
approved these changes
Sep 22, 2023
bkeryan
requested changes
Sep 22, 2023
samchris007
force-pushed
the
users/sam/fix-discoveryservicelaunch-onfreshInstall
branch
from
9cb7cf5 to
81444bc
Compare
bkeryan
approved these changes
Sep 25, 2023
bkeryan
reviewed
Sep 25, 2023
bkeryan
reviewed
Sep 25, 2023
1 task
samchris007
added a commit
that referenced
this pull request
Sep 25, 2023
… a fresh install of MeasurementLink (#397) * Fix launching of discovery service during fresh install
1 task
samchris007
added a commit
that referenced
this pull request
Sep 25, 2023
… a fresh install of MeasurementLink (#397) * Fix launching of discovery service during fresh install
bkeryan
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
When attempting to open the discovery service key file after a fresh install of MeasurementLink (i.e., folders such as
DiscoveryandLogsare not present inC:\ProgramData\National Instruments\MeasurementLink\), thewinerror.ERROR_PATH_NOT_FOUNDexception was thrown because these directories were not present at the start. This exception hadn't been handled in_open_key_file(). This unhandled error resulted in the exception being thrown in the command prompt during the first run of a measurement service alone.To fix this issue, I have made the following changes based on the suggestions provided by @bkeryan.
_open_key_fileto translateERROR_PATH_NOT_FOUNDtoFileNotFoundError, which is handled by its caller (_start_service)_start_serviceto catchOSError._open_key_file(), I have translated all unexpectedwin32file.errorcodes toWindowsErrorWhy should this Pull Request be merged?
Fixes Bug 2514643: Auto-launching discovery service fails after clean install (GitHub Issue #369)
What testing has been done?
Added/Updated unit tests to test the fix.