[releases/1.2] Fix pywintypes error during the launch of the discovery service after a fresh install of MeasurementLink #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* service: Add display_name to ServiceInfo * service: Add DiscoveryService.register_service and deprecate register_measurement_service * tests: Rewrite test_discovery_client to test new API and use mocks * service: Use new register_service method * service: Fix discovery_client.py docs * service: Things we lost in the merge
* Update README.md * Update README.md
…383) * Add DETACHED_PROCESS flag to detach the discovery process from its parent console process * Fix test failure
* Add max_generations so the game of life will stop and is more useful in TestStand * Remove prompt comment * Change the label of the Max Generations input * Add INFINITE_GENERATIONS constant * Run linter * Run linter from a different place * Use INFINITE_GENERATIONS constant for default
…warnings (#384) * workflows: Check documentation * workflows: Install --with docs * workflows: Check sphinx-built exit code * workflows: Tell Sphinx to convert warnings to errors * service: Fix docstring formatting * pyproject.toml: Upgrade doc dependencies * Update poetry.lock * docs: Suppress cross-reference warnings (due to aliases) * service: Split up NamedTuple docstrings Both the "Attributes:" section and autoapi are generating documentation for NamedTuple fields, which leads to warnings like this: WARNING: duplicate object description of ni_measurementlink_service._internal.parameter.metadata.ParameterMetadata.display_name, other instance in autoapi/ni_measurementlink_service/_internal/parameter/metadata/index, use :noindex: for one of them * service: Fix Sphinx "unexpected indent" errors ERROR: Unexpected indentation. WARNING: Block quote ends without a blank line; unexpected unindent. * service: Fix argument indentation and some cross-references * service: Fix lint warnings * service: Fix some cross-references * docs: Fix lint warnings
… initialization code (#386) * service: Update DiscoveryClient to use GrpcChannelPool * service: Update SessionManagementClient to use DiscoveryClient and GrpcChannelPool * service: Pass gRPC channel pool to DiscoveryService * service: Change MeasurementService to defer initialization as much as possible Use lazy initialization for DiscoveryClient and GrpcChannelPool so they can be reinitialized after close_service(). Initialize GrpcService in host_service() and destroy it in close_service(). Deprecate the public grpc_service property and replace with a public service_location property. * service: Fix lint warnings * service: Use double-checked locking in client classes * service: Fix mypy errors * tests: Update test fixtures to take advantage of service changes * tests: Update SessionManagementClient class name * tests: Update unit tests for new constructors * service: Lazily create more objects
…ttps://github.com/ni/measurement-services-python into users/sam/fix-discoveryservicelaunch-onfreshInstall
Collaborator
|
I wrote some instructions for cherry-picking here: https://github.com/ni/measurementlink-python/wiki/Release-Process#cherry-picking |
dixonjoel
deleted the
users/sam/fix-discoveryservicelaunch-onfreshInstall
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick change on fixing the pywintypes error during the launch of the discovery service after a fresh install of MeasurementLink: #397
Why should this Pull Request be merged?
Fixes Bug 2514643: Auto-launching discovery service fails after clean install (GitHub Issue #369)
What testing has been done?
None