service: Include TS code module dir in .env search#485
Merged
Conversation
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
Collaborator
Author
|
@mshafer-NI This implements some of the ideas we discussed earlier. |
Contributor
…g with the code module's parent directory
dixonjoel
approved these changes
Oct 29, 2023
bkeryan
commented
Oct 29, 2023
bkeryan
commented
Oct 29, 2023
In Python 3.11 and later, `traceback.walk_stack(None)` skips more stack frames than in the past: python/cpython#96092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update
.envsearch to include some fallback options if the current directory and its parents don't contain a.envfile:__main__module that exists on disk, use the script pathni_measurementlink_serviceWhy should this Pull Request be merged?
Fixes AB#2565326
What testing has been done?
Ran tests.
Manually tested with nidcpower_source_dc_voltage TestStand sequence.