Conversation
bkeryan
commented
Oct 28, 2023
Contributor
I updated the AMI build to add UNIX tools to the path and install zstandard, so actions/cache should work without this hack (which didn't work anyway).
…rrect Python versions for testing
d67fd6f to
4cab108
Compare
`poetry install` is fast when the dependencies are already installed. Also, if the venv was relocated to a different path, it may fix the venv.
dixonjoel
approved these changes
Oct 30, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
~/.cache/pypoetry/virtualenvs.poetry installmultiple times with different extras and/or dependency groups.poetry.lockfiles. These lock files are not checked into Git, but generating them takes over 5 minutes, so they are worth caching..toxdirectory as well. Caching on the self-hosted runner has significant overhead, but it seems to be an overall win compared to installing from PyPI for each Python version.Publish_NIMS.yml. We don't run this workflow very often and it's better to avoid a possible source of failure.poetry installon cache hits at the time, but I don't want to spend any more time on it.Why should this Pull Request be merged?
Speed up builds (when there is a cache hit):
What testing has been done?
Ran PR workflow.