tests: Reorganize stubs and test measurements #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
dixonjoel,
mshafer-NI,
nstokes-nati and
pbirkhol-ni
as code owners
|
@bkeryan waiting for conflict resolution. PIng me when it's up-to-date. |
dixonjoel
approved these changes
Dec 14, 2023
...tlink_service/_internal/stubs/ni/measurementlink/discovery/v1/discovery_service_pb2_grpc.pyi
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Move test protos and codegen from
tests.assetstotests.utilities.stubs.Move test measurements from
tests.utilitiestotests.utilities.measurements.Uniquify test proto gRPC package names and rename the last element of the Python package name to match.
Rename test measurement configurations and outputs to
ConfigurationsandOutputswhen possible.Why should this Pull Request be merged?
Fixes #495
Follows package naming guidelines more closely
What testing has been done?
poetry run pytest -v