Skip to content

Update README for ni-measurement-generator instead of using template.py#91

Merged
dixonjoel merged 3 commits intomainfrom
users/jdixon/update-generator-instructions
Aug 31, 2022
Merged

Update README for ni-measurement-generator instead of using template.py#91
dixonjoel merged 3 commits intomainfrom
users/jdixon/update-generator-instructions

Conversation

@dixonjoel
Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Correct the instructions now that we have a pypi.org package.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@bkeryan
Copy link
Copy Markdown
Collaborator

bkeryan commented Aug 31, 2022

FYI, I also tried to add @nstokes-nati as a reviewer but his GitHub userid isn't part of the NI organization yet.

@dixonjoel
Copy link
Copy Markdown
Collaborator Author

FYI, I also tried to add @nstokes-nati as a reviewer but his GitHub userid isn't part of the NI organization yet.

I've pinged him on Teams to let us know when he has access.

Comment thread README.md Outdated
@dixonjoel dixonjoel merged commit de36952 into main Aug 31, 2022
@dixonjoel dixonjoel deleted the users/jdixon/update-generator-instructions branch August 31, 2022 16:19
@nstokes-nati
Copy link
Copy Markdown

FYI, I also tried to add @nstokes-nati as a reviewer but his GitHub userid isn't part of the NI organization yet.

I'm officially in. :-) At a glance it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants