Add AdaptsToType="[bool]True" to all .measui files#99
Merged
mikeprosserni merged 3 commits intomainfrom Oct 7, 2022
Merged
Conversation
mikeprosserni
requested review from
bkeryan,
csjall,
dixonjoel and
jonlugoatx
as code owners
Collaborator
|
I think you also need to update this: https://github.com/ni/measurement-services-python/blob/main/ni_measurement_generator/ni_measurement_generator/templates/measurement.measui.mako |
Collaborator
Author
done |
bkeryan
approved these changes
Oct 7, 2022
dixonjoel
approved these changes
Oct 7, 2022
mikeprosserni
deleted the
users/mprosser/update-measuis-with-adapttotype
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
AdaptsToType="[bool]True" is now required on numeric and array controls, so this PR updates all .measui files in this repo.
Why should this Pull Request be merged?
Without this property, the numeric and array controls will not adapt to type.