linux-nilrt: drop "nocheckout" option to get correct source timestamps#623
Merged
amstewart merged 1 commit intoni:nilrt/master/kirkstonefrom Sep 20, 2023
bstreiff:dev/bstreiff/kirkstone/drop-nocheckout
Merged
linux-nilrt: drop "nocheckout" option to get correct source timestamps#623amstewart merged 1 commit intoni:nilrt/master/kirkstonefrom bstreiff:dev/bstreiff/kirkstone/drop-nocheckout
amstewart merged 1 commit intoni:nilrt/master/kirkstonefrom
bstreiff:dev/bstreiff/kirkstone/drop-nocheckout
Conversation
amstewart
reviewed
Sep 19, 2023
Contributor
amstewart
left a comment
amstewart
left a comment
There was a problem hiding this comment.
LGTM. Could you add the AZDO item link and a testing section?
Contributor
|
Also. I'll only merge this into the master branch, since I don't think its really needed for 23.8. Let me know if you disagree. |
kernel builds with "nocheckout=1" behave incorrectly with reproducible builds; the observed behavior is that we get: - do_unpack happens; the git/.git directory is created, and HEAD points to the same commit as nilrt/master/4.14, but it's not actually checked out (no files are present). This is itself kind of weird, since the current default branch for linux.git on GitHub is nilrt/master/6.1. - create_source_date_epoch_stamp happens and now the SOURCE_DATE_EPOCH is latched on this commit - do_kernel_checkout happens after this and that's what puts us on the correct branch (which is what we build) As a result, the SOURCE_DATE_EPOCH we get is for a completely different branch. There doesn't seem to be any reason for why we set "nocheckout=1" at all other than "that's what we started with" (and no other recipes used in nilrt use "nocheckout=1") so take the easy solution and drop it. Natinst-AzDO-ID: 2523534 Signed-off-by: Brenda Streiff <brenda.streiff@ni.com>
amstewart
approved these changes
Sep 20, 2023
pratheekshasn
pushed a commit
to pratheekshasn/meta-nilrt
that referenced
this pull request
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernel builds with "nocheckout=1" behave incorrectly with reproducible builds; the observed behavior is that we get:
As a result, the SOURCE_DATE_EPOCH we get is for a completely different branch.
There doesn't seem to be any reason for why we set "nocheckout=1" at all other than "that's what we started with" (and no other recipes used in nilrt use "nocheckout=1") so take the easy solution and drop it.
Natinst-AzDO-ID: 2523534
Tested with
bitbake linux-nilrtand then inspecting$NILRT_ROOT/build/tmp-glibc/work/x64-nilrt-linux/linux-nilrt/6.1+gitAUTOINC+3494faaf50-r0/deploy-source-date-epoch/__source_date_epoch.txt; it now reads 1694704634, which isThu 14 Sep 2023 10:17:14 AM CDT, which matches the commit time of ni/linux@3494faaf50f2.