-
Notifications
You must be signed in to change notification settings - Fork 1
Autodetect and dispatch test runs #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
- the matrix value is not longer available because it is too far up the call tree Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
- This makes get_package_info run for every os-python combo rather than once This reverts commit 17b5808.
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic test detection and execution for packages in the CI pipeline, eliminating the need for manual workflow file updates when adding new packages.
- Replaces hardcoded package testing with dynamic package discovery and dispatch
- Upgrades grpc_generator to Poetry 2 and extends Python version support
- Refactors CI workflows to use reusable components with package-specific inputs
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test_package.yml | New workflow for testing individual packages with matrix strategy |
| .github/workflows/run_unit_tests.yml | Refactored to accept package inputs instead of hardcoded matrix |
| .github/workflows/CI.yml | Updated to use new test_package workflow |
| .github/actions/run_and_upload_unit_tests/action.yml | Modified to use input parameters instead of matrix variables |
| tools/grpc_generator/pyproject.toml | Upgraded to Poetry 2 with Python 3.9+ support |
| tools/grpc_generator/src/grpc_generator/generator.py | Replaced StrEnum with standard enum for Python 3.9 compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Use runner information rather than an input Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
What does this Pull Request accomplish?
The CI can detect and run tests for each package in
packages.jsontest_package.yml, with similar mechanics ascheck_package.ymlCI.ymlfor each package name inpackages.jsonget_package_info.ymlto determine whether there are tests to run for each packagecheck_package.ymlworkflow_dispatchrun_unit_tests.ymlfor package information, Python version, and OSrun_and_upload_unit_testsgrpc_generatorto Poetry 2grpc_generatorto run with Python 3.9 and 3.10 to remove special test treatmentWhy should this Pull Request be merged?
What testing has been done?
poetry run generate-stubsstill succeeds forgrpc_generator