Skip to content

Rework GitHub actions and check selection #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 8, 2025
Merged

Rework GitHub actions and check selection #120

merged 26 commits into from
Sep 8, 2025

Conversation

@jfriedri-ni
Copy link
Collaborator

@jfriedri-ni jfriedri-ni commented Sep 4, 2025 •
edited
Loading

What does this Pull Request accomplish?

This PR reworks how checks are selected for execution -- package location and features (like protobuf, docs, tests) no longer need special cases or explicit dispatching.

Why should this Pull Request be merged?

  • Minimizes the need to change the workflow files whenever and wherever we add new packages
    • Detect protobuf output and run the generator
    • Detect a docs folder and build the package's docs
    • Detect a tests folder and run the package's tests (detection implemented, running tests coming in a follow-up PR)

What testing has been done?

PR checks run

grpc_generator

grpc_generator runs its analyzers, skips codegen and docgen

get_package_info.yml output
image

Executed steps
image

Discovery client

Has no protobuf files, still skips codegen

image

@jfriedri-ni
Add new outputs to get_package_info
294de53 
- package-basepath
- should-check-codegen
- should-check-docs
- should-run-tests

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Rename 'package-base-path' to 'package-basepath'
216cde6 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use all JSON keys for each package info object
1d56a3d 
- Prefer null objects to empty

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Add and use input for package-basepath to check_docs.yml
af0b453 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use new package info outputs in check_package.yml to skip unneeded jobs
773e047 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Remove special treatment for grpc_generator in the CI
999f6ae 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results

   76 files  ±0     76 suites  ±0   1m 54s ⏱️ -4s
  187 tests ±0    185 ✅ ±0   2 💤 ±0  0 ❌ ±0 
1 850 runs  ±0  1 820 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit ea547b3. ± Comparison against base commit d2d43fb.

♻️ This comment has been updated with latest results.

@jfriedri-ni jfriedri-ni changed the title Rework GitHub actions Rework GitHub actions and check selection Sep 5, 2025
@jfriedri-ni jfriedri-ni marked this pull request as ready for review September 5, 2025 17:54
@jfriedri-ni jfriedri-ni requested a review from bkeryan as a code owner September 5, 2025 17:54
jfriedri-ni
jfriedri-ni commented Sep 5, 2025
View reviewed changes
csjall
csjall approved these changes Sep 5, 2025
View reviewed changes
csjall
csjall reviewed Sep 5, 2025
View reviewed changes
csjall
csjall reviewed Sep 5, 2025
View reviewed changes
@jfriedri-ni jfriedri-ni mentioned this pull request Sep 5, 2025
Closed
@jfriedri-ni
Do not echo back the parsed JSON
fe2bb54 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Merge remote-tracking branch 'origin/main' into users/jfriedri/rework…
42978f5 
…-github-actions
@jfriedri-ni
Incorporate the new no-proto pinmap client package
f45325d 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Add the github workspace path segment to all working-directory parame…
013f42c 
…ters

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Hint that package-basepath is relative with a ./ prefix
3b3ff12 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
bkeryan
bkeryan reviewed Sep 5, 2025
View reviewed changes
@jfriedri-ni
Use absolute basepaths for all step inputs
99a4801 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Revert the workspace root for check analyzers
1d5df59 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Rely on the working directory for the venv path to cache
2e39611 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use relative paths for sub-action inputs
bbc2c4d 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Revert ./ prefix in packages.json
728e49e 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use the default working directory to upload docs
9a89e52 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Revert the absolute path input for run_and_upload_unit_tests
3b6cfd5 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Remove all ./ to build the paths correctly at call sites
3da9712 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Remove intermediate relative path segments
cd7ca06 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use absolute path for upload-artifact because it doesn't use default …
f1c7c98 
…working-directory

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Use absolute path for Python venv cache because the action does not u…
5e8fc02 
…se the default working directory

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Update documentation and defaults in workflow files
9e2fa28 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Merge remote-tracking branch 'origin/main' into users/jfriedri/rework…
b9e2a53 
…-github-actions
@jfriedri-ni
Only leaf workflows should use the repo root for their step inputs
4766a83 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni
Generalize check_analyzers and change 'install-drivers' to 'install-e…
ea547b3 
…xtras'

Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni jfriedri-ni merged commit fd3fd91 into main Sep 8, 2025
97 checks passed
@jfriedri-ni jfriedri-ni deleted the users/jfriedri/rework-github-actions branch September 8, 2025 21:03
@jfriedri-ni jfriedri-ni linked an issue Sep 8, 2025 that may be closed by this pull request
Make grpc_generator more consistent with the rest of the packages. #88
Closed
@jfriedri-ni jfriedri-ni mentioned this pull request Sep 8, 2025
Closed
@jfriedri-ni
Copy link
Collaborator Author

jfriedri-ni commented Sep 11, 2025

Detect a tests folder and run the package's tests (detection implemented, running tests coming in a follow-up PR)

See #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csjall csjall csjall approved these changes

@bkeryan bkeryan bkeryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make grpc_generator more consistent with the rest of the packages.

4 participants

@jfriedri-ni @csjall @bkeryan