Skip to content

Fix tests for ni.measurementlink.sessionmanagement.v1.client #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Fix tests for ni.measurementlink.sessionmanagement.v1.client #145

wants to merge 17 commits into from

Conversation

@jfriedri-ni
Copy link
Collaborator

@jfriedri-ni jfriedri-ni commented Sep 11, 2025

What does this Pull Request accomplish?

Makes the tests for ni.measurementlink.sessionmanagement.v1.client run with Python 3.9.

Why should this Pull Request be merged?

The tests now pass the CI.

What testing has been done?

PR checks

divakar-selvam07 and others added 17 commits September 9, 2025 19:42
@divakar-selvam07
add helpers and update model, constants
fbb980b
@divakar-selvam07
populate the annotations in requests
96f0c74
@divakar-selvam07
update and rename _helpers.py
2eee701
@divakar-selvam07
add win32 error handling
066bda4
@divakar-selvam07
nit: fix lint issue
c025cb8
@divakar-selvam07
Merge branch 'main' of https://github.com/divakar-selvam07/ni-apis-py…
5de09db 
…thon into users/diva/sess-client-populate-client-details
@divakar-selvam07
update lock file
5781faf
@divakar-selvam07
replace importing win32
90055ce
@divakar-selvam07
update lock file
151fedc
@divakar-selvam07
Merge branch 'main' of https://github.com/divakar-selvam07/ni-apis-py…
2b915be 
…thon into users/diva/sess-client-populate-client-details
@divakar-selvam07
remove and replace annotations from package
b170f1b
@divakar-selvam07
fix Brad's feedback
9769235
@divakar-selvam07
update the annotations type
a735a7b
@divakar-selvam07
add tests for annotations
f57e362
@divakar-selvam07
nit: arrange tests
5976cf7
@jfriedri-ni
Merge branch 'main' of https://github.com/ni/ni-apis-python
0dfedb2
@jfriedri-ni
Allow '|' for type hints in Python 3.9
e4e8be4 
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Test Results

   90 files  + 43     90 suites  +43   2m 25s ⏱️ + 1m 28s
  190 tests  -   1    188 ✅ +  2   2 💤  -  2  0 ❌ ±0 
1 900 runs  +943  1 870 ✅ +935  30 💤 +10  0 ❌ ±0 

Results for commit e4e8be4. ± Comparison against base commit 9a43753.

This pull request removes 1 test. 
tests.unit.test_annotations

@jfriedri-ni
Copy link
Collaborator Author

jfriedri-ni commented Sep 11, 2025

See #146

@jfriedri-ni jfriedri-ni deleted the users/jfriedri/fix-sessmgmt-ci branch September 11, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkeryan bkeryan Awaiting requested review from bkeryan bkeryan will be requested when the pull request is marked ready for review bkeryan is a code owner

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel will be requested when the pull request is marked ready for review dixonjoel is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfriedri-ni @divakar-selvam07