Fix tests for ni.measurementlink.sessionmanagement.v1.client #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility issues in the ni.measurementlink.sessionmanagement.v1.client package tests to ensure they run properly with Python 3.9.
- Adds
from __future__ import annotationsto enable forward reference support in Python 3.9
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
bkeryan
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Makes the tests for
ni.measurementlink.sessionmanagement.v1.clientrun with Python 3.9.Why should this Pull Request be merged?
The tests now pass the CI.
What testing has been done?
PR checks