-
Notifications
You must be signed in to change notification settings - Fork 1
ni-grpc-extensions: Stop installing traceloggingdynamic on Linux #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… if sys.platform == "win32" block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the traceloggingdynamic dependency from Linux platforms in the ni-grpc-extensions package and simplifies the code by removing the try/except ImportError pattern. The changes improve platform-specific dependency management now that the PR workflow runs type checkers separately on each platform.
- Removed Linux-specific traceloggingdynamic dev dependency from pyproject.toml
- Replaced direct EventBuilder instantiation with a helper function that throws platform-specific errors on non-Windows systems
- Updated GitHub Actions versions to v0.6.1 across workflow files
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ni-grpc-extensions/src/ni_grpc_extensions/_tracelogging.py | Simplified platform handling by removing try/except blocks and adding helper function for EventBuilder creation |
| packages/ni-grpc-extensions/pyproject.toml | Removed traceloggingdynamic Linux dev dependency |
| .github/workflows/run_unit_tests.yml | Updated GitHub Actions versions |
| .github/workflows/publish.yml | Updated GitHub Actions versions |
| .github/workflows/check_docs.yml | Updated GitHub Actions versions |
| .github/workflows/check_codegen.yml | Updated GitHub Actions versions |
| .github/workflows/check_analyzers.yml | Updated GitHub Actions versions |
| .github/actions/run_and_upload_unit_tests/action.yml | Updated GitHub Actions versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
What does this Pull Request accomplish?
github: Update actions/cache and ni/python-actions from #166
ni-grpc-extensions:
Why should this Pull Request be merged?
Now that the PR workflow runs mypy and Pyright separately on Linux, Mac, and Windows, it no longer makes sense to install traceloggingdynamic on Linux.
Since the last time we visited this issue, we have learned that the "install it on all platforms" approach doesn't work for some modules, like pywin32.
What testing has been done?
PR build