Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Sep 29, 2025

What does this Pull Request accomplish?

github: Update actions/cache and ni/python-actions from #166

ni-grpc-extensions:

  • Remove traceloggingdynamic on Linux from dev dependencies.
  • Remove try/except ImportError from _tracelogging.py. Originally, traceloggingdynamic was an optional dependency, but it is no longer optional.
  • Wrap EventBuilder construction in a helper function and redefine it to throw an unsupported platform exception in non-Windows case.

Why should this Pull Request be merged?

Now that the PR workflow runs mypy and Pyright separately on Linux, Mac, and Windows, it no longer makes sense to install traceloggingdynamic on Linux.

Since the last time we visited this issue, we have learned that the "install it on all platforms" approach doesn't work for some modules, like pywin32.

What testing has been done?

PR build

Copilot AI review requested due to automatic review settings September 29, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the traceloggingdynamic dependency from Linux platforms in the ni-grpc-extensions package and simplifies the code by removing the try/except ImportError pattern. The changes improve platform-specific dependency management now that the PR workflow runs type checkers separately on each platform.

  • Removed Linux-specific traceloggingdynamic dev dependency from pyproject.toml
  • Replaced direct EventBuilder instantiation with a helper function that throws platform-specific errors on non-Windows systems
  • Updated GitHub Actions versions to v0.6.1 across workflow files

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/ni-grpc-extensions/src/ni_grpc_extensions/_tracelogging.py Simplified platform handling by removing try/except blocks and adding helper function for EventBuilder creation
packages/ni-grpc-extensions/pyproject.toml Removed traceloggingdynamic Linux dev dependency
.github/workflows/run_unit_tests.yml Updated GitHub Actions versions
.github/workflows/publish.yml Updated GitHub Actions versions
.github/workflows/check_docs.yml Updated GitHub Actions versions
.github/workflows/check_codegen.yml Updated GitHub Actions versions
.github/workflows/check_analyzers.yml Updated GitHub Actions versions
.github/actions/run_and_upload_unit_tests/action.yml Updated GitHub Actions versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Test Results

  120 files  ±0    120 suites  ±0   3m 26s ⏱️ -4s
  240 tests ±0    238 ✅ ±0   2 💤 ±0  0 ❌ ±0 
2 400 runs  ±0  2 370 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit aa42986. ± Comparison against base commit 6f8c44e.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit c045a15 into main Sep 29, 2025
347 checks passed
@bkeryan bkeryan deleted the users/bkeryan/renovate-github-actions branch September 29, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants