Add conversion functions for waveform and precision timestamp. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
requested changes
Jul 11, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_converters.py
Outdated
Show resolved
Hide resolved
packages/ni.protobuf.types/src/ni/protobuf/types/waveform_converters.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Jul 11, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_converters.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
jfriedri-ni
approved these changes
Jul 14, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_conversion.py
Outdated
Show resolved
Hide resolved
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_conversion.py
Outdated
Show resolved
Hide resolved
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_conversion.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
reviewed
Jul 14, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_conversion.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
requested changes
Jul 14, 2025
packages/ni.protobuf.types/src/ni/protobuf/types/precision_timestamp_conversion.py
Outdated
Show resolved
Hide resolved
packages/ni.protobuf.types/src/ni/protobuf/types/waveform_conversion.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds functions to convert:
DoubleAnalogWaveform->AnalogWaveform(and vice versa)PrecisionTimestamp->bintime.DateTime(and vice versa)This logic was copied from the existing converters and altered slightly because they are no longer members of a class.
These are standalone functions that will be called from the existing
Converterobjects. The desire is to have the minimum logic required to convert from python object to protobuf message inni-apis-pythonand the rest of the conversion infrastructure stay where it is.I also copied the applicable existing unit tests for the conversion logic into
ni-apis-python(test_waveform_conversion.py).To do this, I had to add a dependency on
nitypesand update the lock file. I also had to add a "test" dependency onhightimeso we can use a pre-release version with compatiblefloatinputs.There will be a subsequent PR to update the existing converters to use these lower level converter functions and delete any now-unnecessary unit tests.
Why should this Pull Request be merged?
Part of AB#3164754
What testing has been done?
Unit tests, mypy, styleguide, pyright.