Data Store Client - Add ReadConditionValue and ReadMeasurementValue methods #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asurements.data.v1.client DataStoreClient
Contributor
hunter-ni
requested review from
bkeryan,
dixonjoel and
jfriedri-ni
as code owners
dixonjoel
reviewed
Jan 27, 2026
packages/ni.measurements.data.v1.client/tests/unit/test_data_store_client.py
Show resolved
Hide resolved
dixonjoel
approved these changes
Jan 27, 2026
jfriedri-ni
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This set of changes exposes new
ReadConditionValueandReadMeasurementValuemethods on theDataStoreClientin theni.measurements.data.v1.clientpackage. These methods were recently added to the underlying gRPC service.Why should this Pull Request be merged?
To keep the
DataStoreClient's functionality in sync with that exposed by the corresponding service. In this particular case, this allows for reading published values using theDataStoreClientitself.What testing has been done?
I've added unit test coverage for the added methods similar to that which exists for other methods/RPCs on the Data Store Service.