-
Notifications
You must be signed in to change notification settings - Fork 1
Add ni-grpc-extensions package #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ncy. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
c903a22 to
4e7f718
Compare
mjohanse-emr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple places I had to add mypy/pyright suppressions. I am not sure if these suppressions are acceptable or if I need to fix something to get rid of the errors. I just copied these files from measurements-python-plugin. The only changes I have made were to fix/suppress mypy/pyright/styleguide errors.
packages/ni.grpc.extensions/src/ni_grpc_extensions/_tracelogging.py
Outdated
Show resolved
Hide resolved
|
The |
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
That is because the project you copied this from has less strict mypy settings and does not use pyright at all. |
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
jfriedri-ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the documentation build is not in the artifact download section. Further, the logs for that specific job are not online 🤔
Looking a little more closely, only the jobs that run unit tests have been logged 😔
packages/ni-grpc-extensions/src/ni_grpc_extensions/_tracelogging.py
Outdated
Show resolved
Hide resolved
…lude the suppressed error/warning. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ually rely on previous steps. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
What does this Pull Request accomplish?
Adds grpc channel pool and logging functionality that will be used by other client packages in this repo.
Why should this Pull Request be merged?
Implements AB#3239056
What testing has been done?
Unit tests, mypy, pyright, styleguide.