Skip to content

Conversation

@mjohanse-emr
Copy link
Collaborator

@mjohanse-emr mjohanse-emr commented Aug 21, 2025

What does this Pull Request accomplish?

Adds grpc channel pool and logging functionality that will be used by other client packages in this repo.

Why should this Pull Request be merged?

Implements AB#3239056

What testing has been done?

Unit tests, mypy, pyright, styleguide.

Signed-off-by: Michael Johansen <michael.johansen@ni.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

Test Results

   46 files  ±0     46 suites  ±0   30s ⏱️ ±0s
  144 tests ±0    144 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 424 runs  ±0  1 424 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8535d62. ± Comparison against base commit 38bb5bf.

♻️ This comment has been updated with latest results.

Michael Johansen and others added 8 commits August 21, 2025 15:17
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ncy.

Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
@dixonjoel dixonjoel force-pushed the users/mjohanse/grpc_extensions branch from c903a22 to 4e7f718 Compare August 23, 2025 21:14
Copy link
Collaborator Author

@mjohanse-emr mjohanse-emr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple places I had to add mypy/pyright suppressions. I am not sure if these suppressions are acceptable or if I need to fix something to get rid of the errors. I just copied these files from measurements-python-plugin. The only changes I have made were to fix/suppress mypy/pyright/styleguide errors.

@mjohanse-emr
Copy link
Collaborator Author

The check_docs action isn't running for ni.grpc.extensions. Perhaps that step needs an if: always() statement as well to make sure it runs even if check_codegen is skipped.

@mjohanse-emr mjohanse-emr marked this pull request as ready for review August 25, 2025 14:09
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
@bkeryan
Copy link
Collaborator

bkeryan commented Aug 25, 2025

There are multiple places I had to add mypy/pyright suppressions. I am not sure if these suppressions are acceptable or if I need to fix something to get rid of the errors. I just copied these files from measurements-python-plugin. The only changes I have made were to fix/suppress mypy/pyright/styleguide errors.

That is because the project you copied this from has less strict mypy settings and does not use pyright at all.

Michael Johansen added 2 commits August 25, 2025 12:46
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
@mjohanse-emr mjohanse-emr changed the title Add ni.grpc.extensions package Add ni-grpc-extensions package Aug 25, 2025
Copy link
Collaborator

@jfriedri-ni jfriedri-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the documentation build is not in the artifact download section. Further, the logs for that specific job are not online 🤔

Looking a little more closely, only the jobs that run unit tests have been logged 😔

…lude the suppressed error/warning.

Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Michael Johansen added 2 commits August 25, 2025 16:22
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ually rely on previous steps.

Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
@mjohanse-emr mjohanse-emr merged commit f1ae7ff into main Aug 26, 2025
46 checks passed
@dixonjoel dixonjoel deleted the users/mjohanse/grpc_extensions branch November 18, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants