Skip to content

fix exceptions in deleting a partially constructed task#149

Merged
zhindes merged 1 commit intoni:masterfrom
zhindes:100
Feb 11, 2022
Merged

fix exceptions in deleting a partially constructed task#149
zhindes merged 1 commit intoni:masterfrom
zhindes:100

Conversation

@zhindes
Copy link
Collaborator

@zhindes zhindes commented Feb 10, 2022

Tasks that failed to initialize would except in __del__. The check against a None _task_handle was bad since the handle is a valid ctypes instance. However, the bool conversion for both ctypes.c_uint and ctypes.c_void_p both handle 0/NULL appropriately, so we can use that. Closes #100

@zhindes zhindes requested a review from maxxboehme as a code owner February 10, 2022 21:23
@zhindes zhindes merged commit a8b9d05 into ni:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to clear task and create a new task with same name?

2 participants