Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Oct 3, 2023

What does this Pull Request accomplish?

Increase minimum Python version to 3.8.

Remove Python 3.7-specific dependencies.

tests: Update call to pykka.get_all() to use a keyword argument.

Why should this Pull Request be merged?

NI's Python policy says

NI products that support or integrate with Python will drop official support for all Python versions that have reached their end of life EOL . This should be done at the next release of the product following the EOL date for a given Python version.

Python 3.7's end-of-life date is 2023-06-27.

Dependencies are unlikely to support both 3.7 and 3.12 with the same version, so continuing to support 3.7 would require more Python-version-specific dependency constraints.

What testing has been done?

Ran poetry run pytest -v with Python 3.9.13: 1034 passed, 117 skipped, 36 xfailed, 18 xpassed in 105.07s (0:01:45)

Signed-off-by: Brad Keryan <brad.keryan@ni.com>
The timeout argument is now keyword-only.
jodal/pykka@f4617a0
@bkeryan
Copy link
Collaborator Author

bkeryan commented Oct 4, 2023

Run CI / Run unit tests / Run unit tests (ubuntu-latest, 3.7) Expected — Waiting for status to be reported
Required

Run CI / Run unit tests / Run unit tests (windows-latest, 3.7) Expected — Waiting for status to be reported
Required

Something tells me these aren't going to complete any time soon...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Test Results

       24 files   -        6         24 suites   - 6   32m 34s ⏱️ - 4m 34s
  1 206 tests ±       0    1 045 ✔️ ±       0     161 💤 ±    0  0 ±0 
15 104 runs   - 3 776  13 160 ✔️  - 3 290  1 944 💤  - 486  0 ±0 

Results for commit 731dc16. ± Comparison against base commit a78be0c.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit 0bb9cab into master Oct 5, 2023
@bkeryan bkeryan deleted the users/bkeryan/drop-python-3.7 branch October 5, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants