Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Dec 9, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

In #898 I updated the mypy-protobuf version to ">=3.4,<3.7", but I forgot that Renovate's default rangeStrategy will try to update version ranges like this.

Why should this Pull Request be merged?

Set the mypy-protobuf version in parallel with the grpcio-tools version, which is what controls the oldest compatible protobuf version.

What testing has been done?

PR build

@bkeryan bkeryan enabled auto-merge (squash) December 9, 2025 01:18
@bkeryan bkeryan changed the title Users/bkeryan/mypy protobuf take 2 fix(deps): Rework mypy-protobuf versioning so Renovate won't update the version we use for codegen Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Results

0 files   -     48  0 suites   - 48   0s ⏱️ - 1h 17m 24s
0 tests  -  3 207  0 ✅  -  2 556  0 💤  -    651  0 ❌ ±0 
0 runs   - 62 172  0 ✅  - 49 398  0 💤  - 12 774  0 ❌ ±0 

Results for commit 7ffb0a8. ± Comparison against base commit 8734435.

@zhindes
Copy link
Collaborator

zhindes commented Dec 9, 2025

@bkeryan - FYI 3.9 failed some codegen validation

@bkeryan
Copy link
Collaborator Author

bkeryan commented Dec 9, 2025

@bkeryan - FYI 3.9 failed some codegen validation

Oops, I left 3.9 out of the version block and mypy-protobuf isn't getting installed

@bkeryan bkeryan merged commit f0444fb into master Dec 9, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants