Conversation
m-akinc
commented
Dec 9, 2025
83befe1 to
4efafbd
Compare
4efafbd to
427690a
Compare
m-akinc
commented
Dec 16, 2025
...ace/nimble-angular/label-provider/core/nimble-label-provider-core-with-defaults.directive.ts
Outdated
Show resolved
Hide resolved
m-akinc
commented
Dec 16, 2025
rajsite
reviewed
Dec 16, 2025
rajsite
reviewed
Dec 16, 2025
rajsite
reviewed
Dec 17, 2025
change/@ni-jasmine-parameterized-711eb6c5-ec73-46f8-86d1-90f9e528ecc5.json
Show resolved
Hide resolved
…/nimble into users/makinc/angular19-update
…ar tests and the example app
rajsite
reviewed
Dec 17, 2025
change/@ni-jasmine-parameterized-711eb6c5-ec73-46f8-86d1-90f9e528ecc5.json
Show resolved
Hide resolved
rajsite
reviewed
Dec 17, 2025
rajsite
reviewed
Dec 17, 2025
rajsite
reviewed
Dec 17, 2025
jattasNI
reviewed
Dec 17, 2025
rajsite
reviewed
Dec 17, 2025
change/@ni-jasmine-parameterized-711eb6c5-ec73-46f8-86d1-90f9e528ecc5.json
Show resolved
Hide resolved
rajsite
reviewed
Dec 17, 2025
packages/angular-workspace/nimble-angular/src/thirdparty/directives/checkbox_value_accessor.ts
Show resolved
Hide resolved
Contributor
|
I tried out the Angular example app in the storybook build and didn't see any issues. |
rajsite
reviewed
Dec 17, 2025
Member
rajsite
left a comment
There was a problem hiding this comment.
Looking pretty good! Please reset for one last lookover when feedback addressed.
jattasNI
approved these changes
Dec 17, 2025
rajsite
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Part of the work for AzDO feature 3051218
👩💻 Implementation
eslint-config-angularversion 11packages/angular-workspace/nimble-angular/thirdparty@angular/localization/initfrom label provider directives, which would preventnimble-angularfrom working with compile-time translation. Angular does not have great support (1, 2) for using$localizein a library, but resolved via:polyfills: "@angular/localize/init"to configuration for example app and tests.@angular/localizetotypesarray intsconfigfiles.dist/browsersubdirectory (from rootdistfolder), so had to add explicitoutputPathconfiguration for the example app (to remove the intermediate directory) to keep the Lighthouse tests and the link on the Nimble site working correctly.@angular-eslint/no-host-metadata-property, which no longer exists.🧪 Testing
Automated tests pass. Built SystemLinkShared libraries against updated packages, and extracted localizable strings to ensure all were still captured.
✅ Checklist