Skip to content

Angular 19 update#2786

Merged
rajsite merged 28 commits intomainfrom
users/makinc/angular19-update
Dec 17, 2025
Merged

Angular 19 update#2786
rajsite merged 28 commits intomainfrom
users/makinc/angular19-update

Conversation

@m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Dec 9, 2025

Pull Request

🤨 Rationale

Part of the work for AzDO feature 3051218

👩‍💻 Implementation

  • Updated to TypeScript 5.8.3
  • Updated Angular dependencies to 19.2.17
  • Updated to Angular-19-compatible eslint-config-angular version 11
  • Updated forked Angular files in packages/angular-workspace/nimble-angular/thirdparty
  • Fixed issue with direct import of @angular/localization/init from label provider directives, which would prevent nimble-angular from working with compile-time translation. Angular does not have great support (1, 2) for using $localize in a library, but resolved via:
  • Default output path for built application changed to dist/browser subdirectory (from root dist folder), so had to add explicit outputPath configuration for the example app (to remove the intermediate directory) to keep the Lighthouse tests and the link on the Nimble site working correctly.
  • Removed suppressions for @angular-eslint/no-host-metadata-property, which no longer exists.
  • Various configuration changes from automatic migration

🧪 Testing

Automated tests pass. Built SystemLinkShared libraries against updated packages, and extracted localizable strings to ensure all were still captured.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc force-pushed the users/makinc/angular19-update branch from 83befe1 to 4efafbd Compare December 16, 2025 17:29
@m-akinc m-akinc force-pushed the users/makinc/angular19-update branch from 4efafbd to 427690a Compare December 16, 2025 19:11
@m-akinc m-akinc marked this pull request as ready for review December 17, 2025 20:03
@rajsite rajsite self-requested a review December 17, 2025 20:28
@jattasNI
Copy link
Contributor

I tried out the Angular example app in the storybook build and didn't see any issues.

Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! Please reset for one last lookover when feedback addressed.

@m-akinc m-akinc requested review from jattasNI and rajsite December 17, 2025 22:08
@rajsite rajsite enabled auto-merge (squash) December 17, 2025 22:52
@rajsite rajsite merged commit 5796d17 into main Dec 17, 2025
11 checks passed
@rajsite rajsite deleted the users/makinc/angular19-update branch December 17, 2025 23:00
@jattasNI jattasNI mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants